
| Audited | cloudflare/security-audit-skill at commit c1c8a8c1471069fb0e188eeaff69b8e8db6564a8 |
|---|---|
| Date | 22 October 2026 |
| How it ran | local run on our workstation, full audit, Standard review |
| Verdict after review | Pass with notes (Fail if a High finding remains after review, otherwise Pass with notes) |
Related: Node.js API documentation, part 1 of 2 (October 2026) · Node.js API documentation, part 2 of 2 (October 2026)
Each finding keeps the number it has in the audit report. The rating shown first is the one after review; the first automated rating is listed with it. 0 findings were first rated Medium or High; 0 of them are Medium or High after review. Text marked "From the report" is quoted from the audit report; fixes are suggestions and were not tested. Code locations link to the file and line at the audited commit.
Low after review (8)
From the report
Evidence: For each confirmed medium, high, or critical record, copy the complete source path and target-neutral local reproduction:
The reports are built from text taken from the audited repository (paths, snippets, reproductions). Nothing says to fence or escape it, so markup or links planted in the target can render when the report is opened in a viewer or posted to a tracker. Rated LOW because no rendering path is shown in the pack.
State that target-derived text goes into code fences or is escaped, and that raw HTML and link targets from the target are neutralised.
From the report
Evidence: const LIMITS = Object.freeze({ inputBytes: 5 * 1024 * 1024, nestingDepth: 64, arrayItems: 1000, ... validationErrors: 100 });
It caps bytes, depth, array length and errors, but not fields per object or a total value count, unlike the ledger validator. The input is the parent run's own output and the 5 MiB cap bounds the cost, so this is a consistency gap.
Add objectFields and total-value limits as validate-coverage-ledger.cjs has.
From the report
Evidence: Validator success proves format and ledger consistency only.
Each validator checks its own file. The page admits this, but no step checks that every ledger result fingerprint appears in findings.json or that the report matches the records; only the parent's discipline enforces it.
Add a small cross-check, or a documented parent-side step, covering both directions of the fingerprint match.
From the report
Evidence: function readFileWithinLimit(file) { const noFollow = fs.constants.O_NOFOLLOW; ... (same body at validate-findings.cjs:604)
The file reader, error list, quoting helper and path check exist twice. Only the regexes and a path corpus have parity tests, so the copies can drift apart.
Move readFileWithinLimit, safeQuote, the error list and the path helpers into one shared .cjs module.
From the report
Evidence: if (!Number.isInteger(noFollow) || noFollow === 0 || !Number.isInteger(nonBlock) || nonBlock === 0) { throw new SafeInputError("OS no-follow and nonblocking input protection is unavailable")
Node on Windows defines neither O_NOFOLLOW nor O_NONBLOCK, so both validators reject all input there (validate-coverage-ledger.cjs:721 has the same code). The workflow says a run ends only when both validators pass, and the README requirements list only Node.js. The run can still be closed as incomplete and the failure is loud, so nothing is lost.
Could be higher if: Windows is a supported platform for people running the skill.
Document the validators as POSIX-only, or add a Windows path that opens read-only and compares lstat and fstat identity before reading within the size cap.
skills/security-audit/HUNTING.md:13From the report
Evidence: 2. architecture.md verbatim. (the required hunter prompt parts list has no untrusted-content statement)
A search for 'untrusted', 'prompt injection', 'not instructions' and 'as data' in the main procedure, hunting, reconnaissance and reporting pages found no statement for target content. Reconnaissance output is pasted verbatim into later hunter prompts, so text planted in the target could steer agents or suppress findings. Rated LOW as an omission with no demonstrated exploit.
Could be higher if: Hunters run unsandboxed or with write or network tools on hostile repositories.
Add a trust-boundary paragraph to the main page and to every hunter, verifier, critic and reconnaissance prompt: target content is data, embedded directives are reported as findings, and architecture notes derived from it are untrusted too.
From the report
Evidence: Are there any hardcoded passwords, API keys, tokens, or secrets in the source? (grep for password, secret, apikey, token, Bearer, -----BEGIN, ...)
The procedure sends hunters to find credentials, including ones removed from git history, but no page tells them to mask the value in evidence, payloads or the report. A full secret could then be written into files that are shared or committed.
Could be higher if: Reports are shared or committed with the target repository.
Add a rule that findings and report text give the file, line and type of a secret and at most its first 4 characters.
From the report
Evidence: !/[ .]$/u.test(segment) && !WINDOWS_RESERVED_COMPONENT.test(segment) (and value.includes(":") at line 474)
Legal POSIX names such as aux.c, nul.go, a file with ':' in its name, or one ending in '.' cannot be cited in a trace, evidence or code change. The validator fails loudly, so the finding must be cited another way. validate-coverage-ledger.cjs isSafeRelativePath (line 377) has the same rule.
Validate only traversal and absolute forms, or offer a documented escape for such names.
Info after review (2)
From the report
Evidence: Record missing or incompatible ledgers instead of treating them as empty coverage.
'Incompatible' is never defined, and the schema uses additionalProperties:false, so a future field change silently invalidates earlier runs' findings.json.
Add a required schema_version to the ledger, the findings contract and run-metadata.json, and define what incompatible means.
From the report
Evidence: const UTF8_DECODER = new TextDecoder("utf-8", { fatal: true, ignoreBOM: true });
With ignoreBOM true the BOM stays in the string and JSON.parse fails with 'invalid JSON syntax'. The ledger validator (line 88) does the same. The failure is loud and the fix is to re-save the file, so nothing is lost.
Set ignoreBOM to false, or strip U+FEFF before parsing.